-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(remix-run/react): fix import.meta.hot type clash #8459
fix(remix-run/react): fix import.meta.hot type clash #8459
Conversation
🦋 Changeset detectedLatest commit: a1086b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 it. I always considered this API surface internal, and I seriously doubt any apps are actually relying on custom HMR logic.
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
This PR is another fix related to #8443.
The global
import.meta.hot
types defined in@remix-run/react
are clashing with the types provided by Vite. Since these types were not intended for consumers, I've opted to simplify and just use@ts-expect-error
directives in the two spots that we useimport.meta.hot
(which was typed asany
anyway).