Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix-run/react): fix import.meta.hot type clash #8459

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

markdalgleish
Copy link
Member

This PR is another fix related to #8443.

The global import.meta.hot types defined in @remix-run/react are clashing with the types provided by Vite. Since these types were not intended for consumers, I've opted to simplify and just use @ts-expect-error directives in the two spots that we use import.meta.hot (which was typed as any anyway).

Copy link

changeset-bot bot commented Jan 8, 2024

🦋 Changeset detected

Latest commit: a1086b9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/react Patch
@remix-run/testing Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/dev Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@jacob-ebey jacob-ebey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it. I always considered this API surface internal, and I seriously doubt any apps are actually relying on custom HMR logic.

@markdalgleish markdalgleish merged commit 239543a into dev Jan 9, 2024
5 checks passed
@markdalgleish markdalgleish deleted the markdalgleish/fix-vite-import-meta-hot-types branch January 9, 2024 00:49
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Jan 9, 2024
Copy link
Contributor

github-actions bot commented Jan 9, 2024

🤖 Hello there,

We just published version 2.5.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 2.5.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants