Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): fix post page link href in admin page for blog tutorial #798

Merged
merged 3 commits into from
Dec 2, 2021

Conversation

Hopsken
Copy link
Contributor

@Hopsken Hopsken commented Nov 30, 2021

In admin page, link href for post pages should be /posts/${post.slug} rather than post.slug

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Nov 30, 2021

Hi @Hopsken,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Nov 30, 2021

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This link is actually correct. Thanks to nested routing you don't have to construct full URLs anymore 🎉 Relative links FTW!

@kentcdodds kentcdodds closed this Dec 2, 2021
@Hopsken
Copy link
Contributor Author

Hopsken commented Dec 2, 2021

@kentcdodds Thanks for the reply. However, because of "Nested Routing", without the full URL, the link would be treated as /admin/posts/${post.slug}, which I believe is not implement.

@kentcdodds
Copy link
Member

Gotcha! Thanks for this!

@kentcdodds kentcdodds reopened this Dec 2, 2021
@kentcdodds kentcdodds merged commit ada4158 into remix-run:main Dec 2, 2021
@dylancom
Copy link

dylancom commented Jul 2, 2023

@kentcdodds @Hopsken it seems this error was reintroduced again, since switching to the indie stack?
I just followed the blog tutorial and the posts inside the admin link to: "http://localhost:3000/posts/admin/my-first-post", which should be "http://localhost:3000/posts/my-first-post"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants