-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vite): fix HMR preamble race condition #7919
Conversation
🦋 Changeset detectedLatest commit: 463fb74 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Longterm, I'd like an API that decouples dev-only scripts from prod scripts. For example, I may want to use HMR in development but not ship any JS assets in production.
Also, I could have sworn that using |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
Closes #7863.
This PR fixes a couple issues:
LiveReload
component to behave the same as the existing Remix compiler from a consumer perspective. You can now choose not to render it, forcing you to perform a full refresh to see changes, and you can also render it afterScripts
. I've updated the ordering ofLiveReload
andScripts
in the Vite tests to show this is the case.