Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remix-testing)!: use type aliases instead of interfaces #7369

Closed

Conversation

MichaelDeBoey
Copy link
Member

Just like I did in #7363, #7366, #7367 & #7368

To transition more smoothly, we can start with exporting these public types with a V3_ prefix

This would be something like

export interface RemixStubProps {
  // ...
}
export type V3_RemixStubProps = RemixStubProps;

@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2023

🦋 Changeset detected

Latest commit: 83deeed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/testing Major
create-remix Major
remix Major
@remix-run/architect Major
@remix-run/cloudflare Major
@remix-run/cloudflare-pages Major
@remix-run/cloudflare-workers Major
@remix-run/css-bundle Major
@remix-run/deno Major
@remix-run/dev Major
@remix-run/eslint-config Major
@remix-run/express Major
@remix-run/node Major
@remix-run/react Major
@remix-run/serve Major
@remix-run/server-runtime Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11
Copy link
Contributor

Closing per #7362 (comment)

@brophdawg11 brophdawg11 closed this Sep 8, 2023
@MichaelDeBoey MichaelDeBoey deleted the use-type-aliases_testing branch September 8, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE This change will require a major version bump CLA Signed feat:typescript package:testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants