feat(remix-react): make RouteMatch a generic type #7333
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the `RouteMatch` type is a generic type that supports type inference. So just as you can do `useLoaderData<typeof loader>()`, now you can also do `RouteMatch<typeof loader>`.
🦋 Changeset detectedLatest commit: 7d07b8f The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lpsinger
changed the title
|
Thanks for the PR! This was actually also done as part of the larger type alignment with RR in #7319. Feel free to give it a shot and see if it works for you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the
RouteMatchtype is a generic type that supports type inference. So just as you can douseLoaderData<typeof loader>(), now you can also doRouteMatch<typeof loader>.Testing Strategy: