Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): export Navigation type #7136

Merged
merged 2 commits into from
Aug 13, 2023

Conversation

markdalgleish
Copy link
Member

The Navigation type is exported from react-router but wasn't re-exported from Remix. While it's possible for consumers to get the type via ReturnType<typeof useNavigation>, this is much more ergonomic and matches the expectation set elsewhere in Remix, e.g. both useFetcher and its Fetcher return type are exposed.

Fixes #3866

@markdalgleish markdalgleish self-assigned this Aug 11, 2023
@changeset-bot
Copy link

changeset-bot bot commented Aug 11, 2023

🦋 Changeset detected

Latest commit: 8761423

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/react Minor
@remix-run/testing Minor
create-remix Minor
remix Minor
@remix-run/architect Minor
@remix-run/cloudflare Minor
@remix-run/cloudflare-pages Minor
@remix-run/cloudflare-workers Minor
@remix-run/css-bundle Minor
@remix-run/deno Minor
@remix-run/dev Minor
@remix-run/eslint-config Minor
@remix-run/express Minor
@remix-run/node Minor
@remix-run/serve Minor
@remix-run/server-runtime Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@markdalgleish markdalgleish merged commit 42fe87f into dev Aug 13, 2023
9 checks passed
@markdalgleish markdalgleish deleted the markdalgleish/export-navigation-type branch August 13, 2023 22:51
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Aug 13, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-42fe87f-20230814 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting release This issue has been fixed and will be released soon CLA Signed feat:typescript renderer:react v2 Issues related to v2 apis
Projects
No open projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

2 participants