Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(meta): add thrown error to the meta params #7105

Merged
merged 4 commits into from
Aug 16, 2023
Merged

Conversation

ryanflorence
Copy link
Member

@ryanflorence ryanflorence commented Aug 8, 2023

Closes #3903

  • Docs
  • Tests

Currently there's no access to the error in meta so you can't display a decent meta data for the page. This simply takes the error from the error object and passes it into the matching meta functions.

@changeset-bot
Copy link

changeset-bot bot commented Aug 8, 2023

🦋 Changeset detected

Latest commit: 1a0fe6f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/react Patch
@remix-run/testing Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/dev Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/remix-react/routeModules.ts Outdated Show resolved Hide resolved
packages/remix-react/routeModules.ts Outdated Show resolved Hide resolved
@ryanflorence ryanflorence merged commit 65d3345 into dev Aug 16, 2023
9 checks passed
@ryanflorence ryanflorence deleted the add-error-to-meta branch August 16, 2023 19:02
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Aug 16, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-1d3d86e-20230817 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.0.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting release This issue has been fixed and will be released soon CLA Signed docs feat:links-meta Issues related to links()/meta() renderer:react
Projects
No open projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

4 participants