feat: add prefetch="viewport" support to <Link>
#6433
Conversation
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
🦋 Changeset detectedLatest commit: 748d6a0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Signed-off-by: Logan McAnsh <[email protected]>
mcansh
force-pushed
the
logan/prefetch-viewport
branch
from
c979409
to
ba6a81e
Compare
mcansh
changed the title
prefetch="viewport" support to <Link>
mcansh
force-pushed
the
logan/prefetch-viewport
branch
2 times, most recently
from
b292eac
to
3fd52d2
Compare
Signed-off-by: Logan McAnsh <[email protected]>
| let callback: IntersectionObserverCallback = (entries) => { | ||
| entries.forEach((entry) => { | ||
| setShouldPrefetch(entry.isIntersecting); | ||
| }); | ||
| }; |
There was a problem hiding this comment.
Should the observer be disconnected after prefetch is set? That way the IntersectionObserver doesn't need to keep observing if ref.current is in the viewport
There was a problem hiding this comment.
mostly depends on if we should clean up link preloads when the link leaves the viewport. another thing would be that if it re-enters the vp, should it refetch the loader?
There was a problem hiding this comment.
Removing/re-adding link tags if an element scrolled out of and back into the viewport would be consistent with our prefetch="intent" behavior
mcansh
force-pushed
the
logan/prefetch-viewport
branch
from
3e01f90
to
ee74d1b
Compare
| {...props} | ||
| {...prefetchHandlers} | ||
| ref={mergeRefs(forwardedRef, ref)} |
There was a problem hiding this comment.
Is there any internal react overhead in attaching a ref? This feels potentially troublesome since we now attach a ref to every Link, even if the user didn't forward a ref and if they're not using prefetch="viewport". Does a page with hundreds of links get immediately "slower" with no way for the user to opt out of the refs?
I took a stab at an opt-in ref approach in 44f28f3
There was a problem hiding this comment.
There's no perf hit per @jacob-ebey so going to back out that commit
There was a problem hiding this comment.
Made a small change in 44f28f3 to only attach the ref when prefetch="viewport" is specified so we're not attaching a ton of refs if the viewport option is not used.
This reverts commit 44f28f3.
|
Think this should be good to go now. I'm OOO tomorrow but will see if Jacob can merge once CI passes |
github-actions
bot
added
the
awaiting release
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
github-actions
bot
removed
the
awaiting release
Signed-off-by: Logan McAnsh [email protected]
Closes: https://canary.discord.com/channels/770287896669978684/940264701785423992/1109137291974279239
Testing Strategy: