-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deprecation warnings for v2_normalizeFormMethod #5863
Add deprecation warnings for v2_normalizeFormMethod #5863
Conversation
🦋 Changeset detectedLatest commit: 5a696d1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
if (!window.__remixContext.future.v2_normalizeFormMethod) { | ||
warnOnce( | ||
false, | ||
"⚠️ DEPRECATED: Please enable the `future.v2_normalizeFormMethod` flag to " + | ||
"prepare for the Remix v2 release. Lowercase `useNavigation().formMethod`" + | ||
"values are being normalized to uppercase in v2 to align with the `fetch()` " + | ||
"behavior. For more information, see https://remix.run/docs/hooks/use-navigation" | ||
); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ooh i didn't even think to include deprecations in the browser console
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I've only done it for remix-react related flags so far. Not yet convinced it makes sense to put say a flat routes deprecation log in the console
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR to fix #5874
🤖 Hello there, We just published version Thanks! |
No description provided.