-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix useMatches returning different loader data on sub navigation on client side #5603
Conversation
🦋 Changeset detectedLatest commit: 4a178d1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
Thanks @wizardlyhel! I'll get this merged once CI finishes 👍 |
🤖 Hello there, We just published version Thanks! |
Problem:
useMatches
returning different route match data on sub navigation. This problem isn't obvious because the lastuseMatches
hook call always returns the correct route's loader datahttps://stackblitz.com/edit/remix-run-remix-askr4f?file=app/root.tsx
Navigate between home, test and test 2 page.
useMatches
of the same route (This is fine and it is due to React re-renders)useMatches
but of different route loader data. It is always the current route and the previous routeNotice that the server side console only logs loader data for the correct route