Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dev): HMR + Hot Data Revalidation #5259

Merged
merged 67 commits into from
Feb 22, 2023
Merged

feat(dev): HMR + Hot Data Revalidation #5259

merged 67 commits into from
Feb 22, 2023

Commits on Feb 16, 2023

  1. wip

    @pcattori
    pcattori committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    df0d4a0 View commit details
    Browse the repository at this point in the history

  2. wip

    @pcattori
    pcattori committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    6a9a5ff View commit details
    Browse the repository at this point in the history

  3. wip

    @pcattori
    pcattori committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    44c1fbb View commit details
    Browse the repository at this point in the history

  4. IT LIVES

    @jacob-ebey @pcattori
    jacob-ebey authored and pcattori committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    2c2b322 View commit details
    Browse the repository at this point in the history

  5. revert port

    @jacob-ebey @pcattori
    jacob-ebey authored and pcattori committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    5b31a3e View commit details
    Browse the repository at this point in the history

  6. Updated to completely strip server methods from route modules instead… 

    … of relying on treeshaking. This allows us to easily detect browser vs server code changes and perform the relevant reload task.
    @jacob-ebey @pcattori
    jacob-ebey authored and pcattori committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    fd5bd1d View commit details
    Browse the repository at this point in the history

  7. - remove logs 

    - allow hot.accept("id", cb)
- surface manifest through HMR as "remix:manifest"
- start plumbing for router updates
    @jacob-ebey @pcattori
    jacob-ebey authored and pcattori committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    cbccdcf View commit details
    Browse the repository at this point in the history

  8. - added a few comments 

    - updated warning message
    @jacob-ebey @pcattori
    jacob-ebey authored and pcattori committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    f3d4992 View commit details
    Browse the repository at this point in the history

  9. consistent timestamps for entry and routes

    @pcattori
    pcattori committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    29c20f3 View commit details
    Browse the repository at this point in the history

  10. wip

    @pcattori
    pcattori committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    0430bec View commit details
    Browse the repository at this point in the history

  11. smart hmr: live reload when server needs it, otherwise hmr

    @pcattori
    pcattori committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    56df876 View commit details
    Browse the repository at this point in the history

  12. CSS HMR ✅

    @jacob-ebey @pcattori
    jacob-ebey authored and pcattori committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    5cb03a4 View commit details
    Browse the repository at this point in the history

  13. update in better location to avoid race conditions

    @jacob-ebey @pcattori
    jacob-ebey authored and pcattori committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    78ea28d View commit details
    Browse the repository at this point in the history

  14. comment things a bit

    @jacob-ebey @pcattori
    jacob-ebey authored and pcattori committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    faa371c View commit details
    Browse the repository at this point in the history

  15. more comments

    @jacob-ebey @pcattori
    jacob-ebey authored and pcattori committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    22fc2c9 View commit details
    Browse the repository at this point in the history

  16. always HMR, full reloads are no longer needed

    @jacob-ebey @pcattori
    jacob-ebey authored and pcattori committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    e01b9e5 View commit details
    Browse the repository at this point in the history

  17. detect loader changes for router self-revalidation

    @pcattori
    pcattori committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    cf7ec3f View commit details
    Browse the repository at this point in the history

  18. refactor: compiler returns assets manifest and metafiles for browser/… 

    …server
    @pcattori
    pcattori committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    628062b View commit details
    Browse the repository at this point in the history

  19. refactor: basing hmr updates off of assets manifest routes 

    punting on individual module hmr for mvp
right now, we only do hmr updates at the route level based on manifest
changes
    @pcattori
    pcattori committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    de9e5cd View commit details
    Browse the repository at this point in the history

  20. fix: update react scripts component to use hmr.runtime

    @pcattori
    pcattori committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    e9d81ff View commit details
    Browse the repository at this point in the history

  21. refactor: manifest timestamp

    @pcattori
    pcattori committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    8ba7b32 View commit details
    Browse the repository at this point in the history

  22. fix: prevent duplicate chunks caused by untimestamped imports

    @pcattori
    pcattori committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    6d858bd View commit details
    Browse the repository at this point in the history

  23. feat: log hmr updates including reason and if revalidating

    @pcattori
    pcattori committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    54b26e9 View commit details
    Browse the repository at this point in the history

  24. refactor: hmr messages

    @pcattori
    pcattori committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    6f1770b View commit details
    Browse the repository at this point in the history

  25. fix: do not preload route chunk if hmr already loaded it

    @pcattori
    pcattori committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    54b4476 View commit details
    Browse the repository at this point in the history

  26. refactor(dev): update react-router api call for hmr 

    also add types for react refresh window globals
    @pcattori
    pcattori committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    1dc778a View commit details
    Browse the repository at this point in the history

  27. refactor: manually revalidate until we have more granular apis

    @pcattori
    pcattori committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    9f2cb05 View commit details
    Browse the repository at this point in the history

  28. fix(dev): only do hmr for unstable_dev

    @pcattori
    pcattori committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    bf296b7 View commit details
    Browse the repository at this point in the history

  29. fix(dev): dynamic, configurable unstable_dev port

    @pcattori
    pcattori committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    5449aa0 View commit details
    Browse the repository at this point in the history

  30. fix(dev): only apply hmr for browser routes in dev mode

    @pcattori
    pcattori committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    a5acb65 View commit details
    Browse the repository at this point in the history

  31. wip: test

    @pcattori
    pcattori committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    a0a7643 View commit details
    Browse the repository at this point in the history

  32. fix: detect loader changes when using variable expressions

    @pcattori
    pcattori committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    ddeeeda View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2023

  1. fix: chunk hmr runtime separately 

    so that we don't get multiple copies of `@remix-run/react`
causing the `router` to be `undefined` after HMR updates
    @pcattori
    pcattori committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    5fdd600 View commit details
    Browse the repository at this point in the history

  2. wip: updated typescript so that transforms work in tests 

    remove this once we rewrite as babel transforms
    @pcattori
    pcattori committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    c0d7483 View commit details
    Browse the repository at this point in the history

  3. fix: hash hmr routes as part of assets manifest version 

    so that loader-only changes are detected and waited for
    @pcattori
    pcattori committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    421df1f View commit details
    Browse the repository at this point in the history

  4. chore: update entry to more simply support refresh 

    chore: add back `<LiveReload>` component
    @jacob-ebey @pcattori
    jacob-ebey authored and pcattori committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    5bfef5d View commit details
    Browse the repository at this point in the history

  5. add abort controller for subsequent HMR updates before completion

    @jacob-ebey @pcattori
    jacob-ebey authored and pcattori committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    d84e68f View commit details
    Browse the repository at this point in the history

  6. test(dev): dynamic ports for hmr integration test

    @pcattori
    pcattori committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    e926d17 View commit details
    Browse the repository at this point in the history

  7. fix: hmr caused subsequent navigations to fail 

    Navigations fixed by always using a global cache for modules instead of passing one around. This allows us to assign into it later on and have those surface in the refreshed component tree
fix: always import updated modules regardless of if there is a callback
The lack of this caused dependent modules to not surface in react-refresh as they don't have an accept callback, but still need to execute the module scope up-front for React to be happy here.
test: added tests for navigation, shared modules, and updates before and after navigation
    @jacob-ebey @pcattori
    jacob-ebey authored and pcattori committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    35b4fec View commit details
    Browse the repository at this point in the history

  8. remove comment

    @jacob-ebey @pcattori
    jacob-ebey authored and pcattori committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    98f1062 View commit details
    Browse the repository at this point in the history

  9. revert module changes in favor of updating cache early and in place

    @jacob-ebey @pcattori
    jacob-ebey authored and pcattori committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    98a44c0 View commit details
    Browse the repository at this point in the history

  10. strip import.meta from cjs builds

    @jacob-ebey @pcattori
    jacob-ebey authored and pcattori committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    026b1c4 View commit details
    Browse the repository at this point in the history

  11. test(dev): import.meta support for jest

    @pcattori
    pcattori committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    a74aee4 View commit details
    Browse the repository at this point in the history

  12. fix(server-runtime): fix typechecking

    @pcattori
    pcattori committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    764731f View commit details
    Browse the repository at this point in the history

  13. style(dev): indentation

    @pcattori
    pcattori committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    5974015 View commit details
    Browse the repository at this point in the history

  14. test(dev): reference local remix dev cli

    @pcattori
    pcattori committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    4b87d03 View commit details
    Browse the repository at this point in the history

  15. fix(dev): only send hmr updates for files that changed 

    by having per-file timestamps that only change when file is written
    @pcattori
    pcattori committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    d2b2d14 View commit details
    Browse the repository at this point in the history

  16. refactor(dev): list of isolated chunks for hmr

    @pcattori
    pcattori committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    69bc58f View commit details
    Browse the repository at this point in the history

  17. wip: esbuild loaders for browser route mods

    @pcattori
    pcattori committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    b2bcad9 View commit details
    Browse the repository at this point in the history

  18. refactor(dev): extract transform utils from codemod/

    @pcattori
    pcattori committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    f3ede9e View commit details
    Browse the repository at this point in the history

  19. refactor(dev): remove server-only exports via babel ast transforms

    @pcattori
    pcattori committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    5cc7ea1 View commit details
    Browse the repository at this point in the history

  20. chore(dev): remove unused dependency

    @pcattori
    pcattori committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    8c057a2 View commit details
    Browse the repository at this point in the history

  21. fix(dev): transform jsx

    @pcattori
    pcattori committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    1ce71c2 View commit details
    Browse the repository at this point in the history

  22. fix(dev): mdx browser routes

    @pcattori
    pcattori committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    acd3894 View commit details
    Browse the repository at this point in the history

  23. chore: update yarn.lock

    @pcattori
    pcattori committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    1832413 View commit details
    Browse the repository at this point in the history

  24. chore(react): set preventAssignment to silence warning

    @pcattori
    pcattori committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    686a6e9 View commit details
    Browse the repository at this point in the history

  25. chore: add changset for hmr

    @pcattori
    pcattori committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    24a9587 View commit details
    Browse the repository at this point in the history

  26. update router to experimental

    @jacob-ebey
    jacob-ebey committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    0ec995c View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2023

  1. chore: depend on pre-releases instead of experimentals

    @pcattori
    pcattori committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    de5f190 View commit details
    Browse the repository at this point in the history

  2. test(dev): increase timeouts for hmr test

    @pcattori
    pcattori committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    491726f View commit details
    Browse the repository at this point in the history

  3. test(dev): increase timeout for windows ci

    @pcattori
    pcattori committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    3366bc9 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2023

  1. test(dev): increase timeout to 1m for windows ci

    @pcattori
    pcattori committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    939a30c View commit details
    Browse the repository at this point in the history

  2. test(dev): increase timeout to 2m for windows ci

    @pcattori
    pcattori committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    14e8110 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'dev' into pedro/hmr-adventures

    @pcattori
    pcattori committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    ac53b8b View commit details
    Browse the repository at this point in the history

  4. test(dev): fail immediately when stderr is written to

    @pcattori
    pcattori committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    8f60539 View commit details
    Browse the repository at this point in the history

  5. test(dev): cross-env for NODE_ENV on windows

    @pcattori
    pcattori committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    7068fae View commit details
    Browse the repository at this point in the history

  6. test(dev): revert timeout for windows ci

    @pcattori
    pcattori committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    3121ea6 View commit details
    Browse the repository at this point in the history