Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dev): dev server maintains clean build directories #5223

Merged
merged 5 commits into from
Jan 23, 2023
Merged

fix(dev): dev server maintains clean build directories #5223

merged 5 commits into from
Jan 23, 2023

Conversation

pcattori
Copy link
Contributor

@pcattori pcattori commented Jan 23, 2023 •
edited
Loading

Fixes #2432 #3123

TODO

  • clean when exiting
  • clean before initial build
  • clean before rebuild

@changeset-bot
Copy link

changeset-bot bot commented Jan 23, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 945fbf8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
remix Patch
@remix-run/dev Patch
create-remix Patch
@remix-run/css-bundle Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pcattori pcattori marked this pull request as draft January 23, 2023 18:33
@pcattori pcattori changed the title fix(dev): clean up build directories when dev server process is terminated fix(dev): dev server maintains clean build directories Jan 23, 2023
@pcattori pcattori marked this pull request as ready for review January 23, 2023 19:02
@pcattori pcattori merged commit f8000db into dev Jan 23, 2023
@pcattori pcattori deleted the pedro/dev2-clean branch January 23, 2023 19:52
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Jan 23, 2023
This was referenced Jan 23, 2023
Closed
Closed
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-8346ace-20230124 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@mcansh mcansh mentioned this pull request Jan 24, 2023
Merged
@izznat izznat mentioned this pull request Jan 25, 2023
Closed
1 task
This was referenced Jan 26, 2023
Closed
Merged
@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Jan 30, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.12.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@ngbrown ngbrown mentioned this pull request May 6, 2023
Merged
@pcattori pcattori mentioned this pull request Jul 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelDeBoey MichaelDeBoey MichaelDeBoey approved these changes

Assignees
No one assigned
Labels
CLA Signed package:dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcattori @MichaelDeBoey