Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: tsconfig path mappings require baseUrl property #482

Merged
merged 4 commits into from
Dec 8, 2021

Conversation

mskoroglu
Copy link
Contributor

Path mappings require baseUrl property.
TSConfig Reference: https://www.typescriptlang.org/tsconfig#paths

{
  "compilerOptions": {
    "baseUrl": ".", // this must be specified if "paths" is specified.
    "paths": {
      ...
    }
  }
}

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Nov 23, 2021

Hi @mskoroglu,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Nov 23, 2021

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@@ -8,6 +8,7 @@
"resolveJsonModule": true,
"target": "ES2019",
"strict": true,
"baseUrl": ".",
Copy link
Member

@MichaelDeBoey MichaelDeBoey Nov 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also be changed in the examples

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Michael!

I changed the files: 41fe1de

@mcansh mcansh changed the title [tsconfig] Path mappings require baseUrl property chore: tsconfig path mappings require baseUrl property Dec 8, 2021
@mcansh mcansh merged commit 3dc07ca into remix-run:dev Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants