Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(remix-node): update @remix-run/web-fetch to 4.3.2 #4644

Merged
merged 4 commits into from
Nov 18, 2022
Merged

fix(remix-node): update @remix-run/web-fetch to 4.3.2 #4644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
59212c2
chore: update @remix-run/web-fetch to 4.3.2
jacob-ebey Nov 18, 2022
8a5c060
Create moody-cats-relax.md
jacob-ebey Nov 18, 2022
2cbf844
Update moody-cats-relax.md
jacob-ebey Nov 18, 2022
7d3f0ed
update snapshots
jacob-ebey Nov 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changeset/moody-cats-relax.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
"remix": patch
"@remix-run/node": patch
---

chore: update @remix-run/web-fetch to 4.3.2

- fix: Memory leak caused by unregistered listeners. Solution was copied from a node-fetch pr.
- fix: Add support for custom "credentials" value. Nothing is done with them at the moment but they pass through for the consumer of the request to access if needed.
1 change: 1 addition & 0 deletions packages/remix-architect/__tests__/server-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,7 @@ describe("architect createRemixRequest", () => {
"type": null,
},
Symbol(Request internals): Object {
"credentials": "same-origin",
"headers": Headers {
Symbol(query): Array [
"accept",
Expand Down
1 change: 1 addition & 0 deletions packages/remix-express/__tests__/server-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,7 @@ describe("express createRemixRequest", () => {
"type": null,
},
Symbol(Request internals): Object {
"credentials": "same-origin",
"headers": Headers {
Symbol(query): Array [
"cache-control",
Expand Down
1 change: 1 addition & 0 deletions packages/remix-netlify/__tests__/server-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,7 @@ describe("netlify createRemixRequest", () => {
"type": null,
},
Symbol(Request internals): Object {
"credentials": "same-origin",
"headers": Headers {
Symbol(query): Array [
"cookie",
Expand Down
2 changes: 1 addition & 1 deletion packages/remix-node/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"sideEffects": false,
"dependencies": {
"@remix-run/server-runtime": "1.7.6",
"@remix-run/web-fetch": "^4.3.1",
"@remix-run/web-fetch": "^4.3.2",
"@remix-run/web-file": "^3.0.2",
"@remix-run/web-stream": "^1.0.3",
"@web3-storage/multipart-parser": "^1.0.0",
Expand Down
1 change: 1 addition & 0 deletions packages/remix-vercel/__tests__/server-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,7 @@ describe("vercel createRemixRequest", () => {
"type": null,
},
Symbol(Request internals): Object {
"credentials": "same-origin",
"headers": Headers {
Symbol(query): Array [
"cache-control",
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2255,10 +2255,10 @@
"@remix-run/web-stream" "^1.0.0"
web-encoding "1.1.5"

"@remix-run/web-fetch@^4.3.1":
version "4.3.1"
resolved "https://registry.npmjs.org/@remix-run/web-fetch/-/web-fetch-4.3.1.tgz"
integrity sha512-TOpuJo3jI7/qJAY0yTnvNJRQl4hlWAOHUHYKAbEddcLFLydv+0/WGT6OaIurJKsBFJJTjooe3FbKiP74sUIB/g==
"@remix-run/web-fetch@^4.3.2":
version "4.3.2"
resolved "https://registry.npmjs.org/@remix-run/web-fetch/-/web-fetch-4.3.2.tgz#193758bb7a301535540f0e3a86c743283f81cf56"
integrity sha512-aRNaaa0Fhyegv/GkJ/qsxMhXvyWGjPNgCKrStCvAvV1XXphntZI0nQO/Fl02LIQg3cGL8lDiOXOS1gzqDOlG5w==
dependencies:
"@remix-run/web-blob" "^3.0.4"
"@remix-run/web-form-data" "^3.0.3"
Expand Down