fix(remix-dev): write other server build output files to assetsBuildDirectory

[mcansh]

(cherry picked from commit 6ae5cdf)

Signed-off-by: Logan McAnsh [email protected]

closes #3414
closes #3415

Closes: #

• Docs
• Tests

Testing Strategy:

[changeset-bot]

🦋 Changeset detected

Latest commit: 8dea114

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages

Name	Type
remix	Patch
@remix-run/dev	Patch
create-remix	Patch
@remix-run/architect	Patch
@remix-run/cloudflare	Patch
@remix-run/cloudflare-pages	Patch
@remix-run/cloudflare-workers	Patch
@remix-run/deno	Patch
@remix-run/eslint-config	Patch
@remix-run/express	Patch
@remix-run/netlify	Patch
@remix-run/node	Patch
@remix-run/react	Patch
@remix-run/serve	Patch
@remix-run/server-runtime	Patch
@remix-run/vercel	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[kentcdodds]

Ok, to make sure I understand, we're now writing static files to both the public directory as well as the server build directory because those static files can be accessed by both sides of the app right?

I wonder if there's a way for us to determine which side of the app needs it. I'm worried that we'd have issues in serverless situations where you're limited on the amount of content you can upload 🤔

[mcansh]

Ok, to make sure I understand, we're now writing static files to both the public directory as well as the server build directory because those static files can be accessed by both sides of the app right?

correct

I wonder if there's a way for us to determine which side of the app needs it. I'm worried that we'd have issues in serverless situations where you're limited on the amount of content you can upload 🤔

totally a valid concern, I'll check it out

edit: looks like we only get back path, contents (bytes), and text (content as string)
edit 2: i think the metafile has what we want
edit 3: jk that's only server things, so we won't know the client files - and doesn't include output files

[kentcdodds]

Let's ask @jacob-ebey about this. I have a feeling he'd know the implications of us copying these files over better.

[ni554n]

Hi, is this going fix the extraneous tailwind .css files generating in functions/_assets directory?

[mcansh]

Hi, is this going fix the extraneous tailwind .css files generating in functions/_assets directory?

it will, yes, sorry about that 😬

[houmark]

Just adding my concern with this one. Cloudflare workers are very limited in size, so a few assets copied to the server build directory could easily block building I think.

[mcansh]

Just adding my concern with this one. Cloudflare workers are very limited in size, so a few assets copied to the server build directory could easily block building I think.

valid concern, the only extra files that should be written to the build directory would be those imported in resource routes

[houmark]

valid concern, the only extra files that should be written to the build directory would be those imported in resource routes

Thanks @mcansh, but not 100% sure I understand that reply. If I have image files, for example, inside a resource route, will those be imported into the build directory, and will those be part of the cloud function itself, meaning it will count to a potential limit of that cloud service (ie. currently 1MB at Cloudflare)?

New to Remix and new to Cloudflare Pages, so just want to understand what one can expect here. I know best practice is to use a static asset storage, so one would not want to add many image files as imports, but there can be some situations where that is needed.

[mcansh]

If I have image files, for example, inside a resource route, will those be imported into the build directory, and will those be part of the cloud function itself, meaning it will count to a potential limit of that cloud service (ie. currently 1MB at Cloudflare)?

they will end up in the public/build directory, yes, but for CF, they'll be uploaded to KV just like your other assets so it shouldn't affect your function size, currently if you import a file only in a resource route, that file is completely ignored.

[github-actions]

🤖 Hello there,

We just published version v0.0.0-nightly-b1b3759-20220928 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!