fix(remix-dev): fix Yarn PnP resolve issue #3579
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: (no issue yet - can create one if you like)
Testing Strategy:
There isn't currently an easy way for us to test yarn pnp / Remix compatibility, so this is just a local manual test.
Before this change (current dev branch, when running
remix build
, multiple errors (as below) appear, I guess because yarn cannot resolve the paths generated by theNodeModulesPolyfills
plugin, unless theesbuild-plugin-pnp
plugin runs first. I'm guessing the pnp plugin needs to set up some path transformation stuff before the polyfill plugin, but the docs for both are super light so I'm not 100% sure why it fixes the errors, but it does.Thankfully when not using yarn pnp,
esbuild-plugin-pnp
is a no-op, so no risk to non-yarn users either way.Errors before change