feat: allow any tsconfig/jsconfig path aliases #320
Conversation
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
mcansh
changed the title
mcansh
requested review from
mjackson and
jacob-ebey
and removed request for
mjackson and
jacob-ebey
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
| @@ -29,6 +28,7 @@ export default function App() { | |||
| <p>This page was rendered at {data.date.toLocaleString()}</p> | |||
| </footer> | |||
| <Scripts /> | |||
| <LiveReload /> | |||
There was a problem hiding this comment.
Can you please make this change in a separate PR if it still needs to be done?
| @@ -351,8 +351,20 @@ async function createServerBuild( | |||
| }); | |||
| } | |||
|
|
|||
| function isBareModuleId(id: string): boolean { | |||
| return !id.startsWith(".") && !id.startsWith("~") && !path.isAbsolute(id); | |||
| function isBareModuleId( | |||
There was a problem hiding this comment.
Instead of mixing bare module id detection code with path prefix detection, let's make a separate function called isPrefixedModuleId or something like that and include the ~ check there as well.
| @@ -0,0 +1,4 @@ | |||
| /.cache | |||
There was a problem hiding this comment.
Can we add the tutorial-js fixture in another PR? Why does it need to be part of this work?
There was a problem hiding this comment.
for sure, just added it to make sure it all works 👍
|
Don't feel like you have to fix all this right now @mcansh. I'd say let's table this work for now and move onto higher priority stuff for the 1.0 launch. I just wanted to leave some notes for when we come back to it in the future. |
most of this is built into esbuild itself, except how we're handling external modules and we need to manually update the paths in the mdx plugin
Signed-off-by: Logan McAnsh [email protected]