Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix-dev/cli/init): only run npm install when package.json is available #3146

Conversation

MichaelDeBoey
Copy link
Member

This will otherwise give the following error:

npm ERR! code ENOENT
npm ERR! syscall open
npm ERR! path .../remix.init/package.json
npm ERR! errno -2
npm ERR! enoent ENOENT: no such file or directory, open '.../remix.init/package.json'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent 

npm ERR! A complete log of this run can be found in:
npm ERR!     .../.npm/_logs/2022-05-09T22_37_36_176Z-debug.log

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call 👍

@kentcdodds kentcdodds merged commit 21c1187 into remix-run:dev May 9, 2022
@MichaelDeBoey MichaelDeBoey deleted the only-run-npm-install-when-package-json-is-present branch May 9, 2022 22:46
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-cbd996f-20220510 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

christophertrudel pushed a commit to christophertrudel/remix that referenced this pull request May 16, 2022
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v1.5.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants