Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: clean directories before initial builds #2875

Merged
merged 2 commits into from
Apr 20, 2022

Conversation

jacob-ebey
Copy link
Member

Closes: #

  • Docs
  • Tests

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we put this in buildEverything in compiler.ts? That way it can be in one place and it'll get cleared between builds in watch mode as well.

@jacob-ebey
Copy link
Member Author

Could we put this in buildEverything in compiler.ts? That way it can be in one place and it'll get cleared between builds in watch mode as well.

buildEverything is actually called for re-builds as well in dev mode. We cleared out inbetween builds in the past and it caused some issues with missing assets, etc. I'd rather keep it explicit in the CLI commands layer, not compiler layer.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds fine to me 👍 Thanks for explaining that to me.

@kentcdodds kentcdodds merged commit 78e0e2b into dev Apr 20, 2022
@kentcdodds kentcdodds deleted the jacob/rem-1015-auto-cleanup-build-directory branch April 20, 2022 21:23
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-a9f2dde-20220426 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-cc69c1b-20220427 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v1.4.2-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v1.4.2 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@nicksrandall
Copy link
Contributor

nicksrandall commented Apr 27, 2022

@kentcdodds @jacob-ebey this breaks most of the "stacks" as the "server.js" file is deleted before the server can start. IMHO, I think this change needs to be reverted until we figure out how to handle these cases. This change has broken my app in other ways was well but I might be specific to just me.

For example, I use this sugggestion to add font files to my _assets folder and now they are being cleared as well before they can be used. #1153 (comment)

@kentcdodds
Copy link
Member

Thanks @nicksrandall.

Let's get this reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants