-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: clean directories before initial builds #2875
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we put this in buildEverything
in compiler.ts
? That way it can be in one place and it'll get cleared between builds in watch mode as well.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds fine to me 👍 Thanks for explaining that to me.
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
@kentcdodds @jacob-ebey this breaks most of the "stacks" as the "server.js" file is deleted before the server can start. IMHO, I think this change needs to be reverted until we figure out how to handle these cases. This change has broken my app in other ways was well but I might be specific to just me. For example, I use this sugggestion to add font files to my |
Thanks @nicksrandall. Let's get this reverted. |
This reverts commit 78e0e2b.
Closes: #