feat: deprecate all functions & types exported from magicExports
#2735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelDeBoey
force-pushed
the
deprecate-magicExports
branch
from
020788e
to
3858831
Compare
|
We'll want to wait until #2670 is merged and released before merging this. |
MichaelDeBoey
force-pushed
the
deprecate-magicExports
branch
2 times, most recently
from
76aa481
to
6f745e1
Compare
|
@MichaelDeBoey Heads up that some on the team are out next week, but I suspect we'll come back to this when they're back. We may not get the deprecation notices out until then. |
MichaelDeBoey
force-pushed
the
deprecate-magicExports
branch
from
6f745e1
to
f645ab2
Compare
MichaelDeBoey
force-pushed
the
deprecate-magicExports
branch
2 times, most recently
from
5311c7d
to
0fab37f
Compare
MichaelDeBoey
force-pushed
the
deprecate-magicExports
branch
from
0fab37f
to
205b9b1
Compare
|
Holding off on warnings for deprecations for a couple more weeks. Will re-open once we are ready for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up of #2731, this will show deprecation warnings in the IDE + in console whenever people aren't using the ESLint config.
Inspired by @pcattori's remark (#2542 (comment)) on @mjackson's PR to rename
createCloudflareKVSessionStoragetocreateWorkersKVSessionStorage(#2542).Since each package is on it's own, I had to copy/paste the
warn&getDeprecatedMessagefunctions over to each package.If this somehow could be simplified (as this is doing the same thing over & over again), I'd be happy to do so.