Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cleanup dist directories when dev mode ends #252

Merged
merged 1 commit into from
Aug 20, 2021
Merged

feat: cleanup dist directories when dev mode ends #252

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/remix-dev/cli/commands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import * as path from "path";
import * as fse from "fs-extra";
import signalExit from "signal-exit";
import prettyMs from "pretty-ms";
import WebSocket from "ws";
Expand Down Expand Up @@ -76,6 +77,11 @@ export async function watch(
})
);

signalExit(() => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

signal-exit doesn't seem to support async here. Without sync the directories are not cleaned up.

fse.emptyDirSync(config.assetsBuildDirectory);
fse.emptyDirSync(config.serverBuildDirectory);
});

console.log(`💿 Built in ${prettyMs(Date.now() - start)}`);
}

Expand Down