-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(example): add an example of using remix-auth Auth0 strategy #1674
docs(example): add an example of using remix-auth Auth0 strategy #1674
Conversation
Hi @himorishige, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
examples/remix-auth-auth0/README.md
Outdated
@@ -0,0 +1,23 @@ | |||
# Remix Auth - Auth0Strategy | |||
|
|||
Authentication using Remix Auth with the GitHubStrategy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Authentication using Remix Auth with the GitHubStrategy. | |
Authentication using Remix Auth with the Auth0Strategy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
I fixed it.
|
||
type LoaderData = { profile: Auth0Profile }; | ||
|
||
export const action: ActionFunction = async ({ request }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is not needed, for logout there’s another URL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was implemented incorrectly... I fixed it.
@@ -0,0 +1,7 @@ | |||
export const AUTH0_RETURN_TO_URL = process.env.AUTH0_RETURN_TO_URL!; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe rename it as .server.ts? Since it uses env variables it should never be sent to the client
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I got it.
I rename it.
@sergiodxa if this looks good to you, let me know and I'll merge :) |
It looks good 👍 |
Add an example of using remix-auth Auth0 strategy