update tutorial to use db variable for continuity #1602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier in the tutorial the pattern have been using `db` in stead of `prisma`. When `prisma` suddenly is used in the seed and only the highlighted diff is copied to the editor, the seed function will fail as `prisma` is not defined. However, `db` is if the user have copied `seed.ts` from earlier in the tutorial.
|
Hi @joms, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
joms
changed the title
anmonteiro
pushed a commit
to anmonteiro/remix
that referenced
this pull request
Feb 8, 2022
…-run#1602) * update tutorial to use db varaible for continuity Earlier in the tutorial the pattern have been using `db` in stead of `prisma`. When `prisma` suddenly is used in the seed and only the highlighted diff is copied to the editor, the seed function will fail as `prisma` is not defined. However, `db` is if the user have copied `seed.ts` from earlier in the tutorial. * Update contributors.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier in the tutorial the pattern have been using
dbin stead ofprisma. Whenprismasuddenly is used in the seed and only the highlighted diff is copied to the editor, the seed function will fail asprismais not defined. However,dbis if the user have copiedseed.tsfrom earlier in the tutorial.