docs(examples): add Material UI example #1441
Conversation
|
|
||
| // Add the emotion style tags after the insertion point meta tag | ||
| const markup = html.replace( | ||
| /<meta(\s)*name="emotion-insertion-point"(\s)*content="emotion-insertion-point"(\s)*\/>/, |
There was a problem hiding this comment.
I think this could be much simpler if this were something like __STYLES__ (like the styled-components example).
There was a problem hiding this comment.
@kentcdodds I think it is correct because in the styled-components example the STYLES was replaced from the extracted CSS and in material-UI, we need to add the emotion style tags after the insertion point meta tags and this is a one-time thing as shown in the official material-UI examples.
| @@ -0,0 +1,53 @@ | |||
| # Material-UI Example | |||
There was a problem hiding this comment.
This README doesn’t follow the other examples style, for example it doesn’t have a button to try it in CodeSandbox
Co-authored-by: Michaël De Boey <[email protected]>
|
I think you may need to apply the same strategy that's done in #1485 to avoid some pit-falls with CSS-in-JS. Can you give that a look? |
kentcdodds
added
the
needs-response
MichaelDeBoey
changed the title
MichaelDeBoey
removed
the
needs-response
No description provided.