Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix invalid custom routes example in conventions.md #1174

Merged
merged 3 commits into from
Jan 12, 2022
Merged

docs: fix invalid custom routes example in conventions.md #1174

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5321a22
Update conventions.md
arvigeus Dec 21, 2021
2c651c5
Update contributors.yml
arvigeus Dec 21, 2021
8177eb3
Merge branch 'main' into patch-2
kentcdodds Jan 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions contributors.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
- alexuxui
- arange
- arganaphangquestian
- arvigeus
- ascorbic
- ashleyryan
- ashocean
Expand Down
4 changes: 2 additions & 2 deletions docs/api/conventions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ exports.routes = async (defineRoutes) => {
// A common use for this is catchall routes.
// - The first argument is the React Router path to match against
// - The second is the relative filename of the route handler
route("/some/path/*", "catchall.tsx")
route("/some/path/*", "catchall.tsx");

// if you want to nest routes, use the optional callback argument
route("some/:path", "some/route/file.js", () => {
Expand All @@ -61,7 +61,7 @@ exports.routes = async (defineRoutes) => {
route("relative/path", "some/other/file")
});

}
})
}
```

Expand Down