fix(doc): remove trailing slash from anchored links #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because it leads to client side navigation errors: the canonical URL has no trailing slash
|
Hi @real34, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
chaance
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because it leads to client side navigation errors: the canonical URL has no trailing slash
I noticed that on https://remix.run/docs/en/v1/api/conventions#handle, the
useMatcheslink redirects to https://remix.run/docs/en/v1.0.6/api/remix/#usematchesWhen SSR'd (e.g: open in new tab) it renders properly because of a 302 to https://remix.run/docs/en/v1.0.6/api/remix#usematches (trailing URL slash removed).
On client side navigation it leads to a 404.
vokoscreen-2021-12-14_04-58-22.mp4
Next
I've only searched for occurrences in this documentation page. The doc may contain other ones.
It may also be considered as a bug with Remix itself and may need a fix in the client-side navigation default patterns? (not sure what does the 302 on the deployed instance - if it comes from fly.io or remix server)