Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default author to "git commit ..." in the initial commit initialization step #10115

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

klibardi
Copy link

When run in an environment where git global config has not been set via

git config --global user.email "[email protected]"
git config --global user.name "Your Name"

and cannot be inferred from local username and hostname, the initialization process fails (git exits with exit code 128).

Closes: #

  • Docs
  • Tests

Testing Strategy:

Manual, just tried running it with various git setups.

Copy link

changeset-bot bot commented Oct 15, 2024

⚠️ No Changeset found

Latest commit: a03f5c5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Oct 15, 2024

Hi @klibardi,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Oct 15, 2024

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

…zation step

When run in an environment where git global config has not been set via
```
git config --global user.email "[email protected]"
git config --global user.name "Your Name"
```
and cannot be inferred from local username and hostname, the initialization process fails (git exits with exit code 128). Setting a default
@klibardi klibardi force-pushed the fix-remix-create-when-no-global-git-config branch from 06e9dcd to a03f5c5 Compare October 16, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants