Add unstable support for routes.ts
#10107
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ec9aa74 The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brophdawg11
reviewed
Oct 15, 2024
brophdawg11
reviewed
Oct 15, 2024
brophdawg11
reviewed
Oct 15, 2024
brophdawg11
approved these changes
Oct 15, 2024
markdalgleish
changed the title
routes.tsroutes.ts
markdalgleish
commented
Oct 18, 2024
Comment on lines
+8
to
+20
| export type { | ||
| DefineRoutesFunction as UNSAFE_DefineRoutesFunction, | ||
| RouteManifest as UNSAFE_RouteManifest, | ||
| RouteManifestEntry as UNSAFE_RouteManifestEntry, | ||
| RouteConfig as UNSAFE_RouteConfig, | ||
| RouteConfigEntry as UNSAFE_RouteConfigEntry, | ||
| } from "./config/routes"; | ||
| export { | ||
| defineRoutes as UNSAFE_defineRoutes, | ||
| routeManifestToRouteConfig as UNSAFE_routeManifestToRouteConfig, | ||
| getRouteConfigAppDirectory as UNSAFE_getRouteConfigAppDirectory, | ||
| } from "./config/routes"; | ||
| export { flatRoutes as UNSAFE_flatRoutes } from "./config/flat-routes"; |
There was a problem hiding this comment.
This isn't needed in React Router because @remix-run/dev/routes has access to the internals of the dev package, whereas in this case we need to expose these internals across package boundaries.
| @@ -476,6 +476,143 @@ You may find some usage for the new [`<Link discover>`][discover-prop] API if yo | |||
|
|
|||
| Opt into automatic [dependency optimization][dependency-optimization] during development. This flag will remain in an "unstable" state until React Router v7 so you do not need to adopt this in your Remix v2 app prior to upgrading to React Router v7. | |||
|
|
|||
| ## routes.ts | |||
|
|
|||
| Config-based routing is the new default in React Router v7. Support for `routes.ts` and its related APIs in Remix are designed as a migration path to help minimize the number changes required when moving your Remix project over to React Router v7. Since React Router v7 is not yet stable, these APIs are also considered unstable. | |||
There was a problem hiding this comment.
Suggested change
| Config-based routing is the new default in React Router v7. Support for `routes.ts` and its related APIs in Remix are designed as a migration path to help minimize the number changes required when moving your Remix project over to React Router v7. Since React Router v7 is not yet stable, these APIs are also considered unstable. | |
| Config-based routing is the new default in React Router v7. Support for `routes.ts` and its related APIs in Remix are designed as a migration path to help minimize the number of changes required when moving your Remix project over to React Router v7. Since React Router v7 is not yet stable, these APIs are also considered unstable. |
brophdawg11
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See changeset and docs for more details.