fix(dev): forcibly kill app server during dev

remix-run · Apr 26, 2023 · dd93875 · dd93875
1 parent 6aa3381
commit dd93875
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/.changeset/soft-laws-cry.md b/.changeset/soft-laws-cry.md
@@ -0,0 +1,5 @@
+---
+"@remix-run/dev": patch
+---
+
+forcibly kill app server during dev
diff --git a/packages/remix-dev/devServer_unstable/index.ts b/packages/remix-dev/devServer_unstable/index.ts
@@ -206,5 +206,8 @@ let kill = async (p?: execa.ExecaChildProcess) => {
     await execa("taskkill", ["/pid", String(p.pid), "/f", "/t"]);
     return;
   }
-  p.kill();
+
+  // wait one tick of the event loop so that we guarantee app server gets killed before proceeding
+  p.kill("SIGTERM", { forceKillAfterTimeout: 0 });
+  await new Promise((resolve) => setTimeout(resolve, 0));
 };