Skip to content

Commit

Permalink
Bump remix to RR 6.4.4 and drop history dependency (#4702)
Browse files Browse the repository at this point in the history
  • Loading branch information
brophdawg11 committed Dec 1, 2022
1 parent d92689a commit 902bdbd
Show file tree
Hide file tree
Showing 12 changed files with 29 additions and 46 deletions.
4 changes: 2 additions & 2 deletions packages/remix-react/__tests__/transition-test.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { Action, parsePath } from "history";
import type { Location, State } from "history";
import { NavigationType as Action, parsePath } from "react-router-dom";
import type { Location } from "react-router-dom";

import type { Submission, TransitionManagerInit } from "../transition";
import {
Expand Down
13 changes: 8 additions & 5 deletions packages/remix-react/browser.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
// TODO: We eventually might not want to import anything directly from `history`
// and leverage `react-router` here instead
import type { BrowserHistory, Update } from "history";
import { createBrowserHistory } from "history";
import type { BrowserHistory, Action, Location } from "@remix-run/router";
import { createBrowserHistory } from "@remix-run/router";
import type { ReactElement } from "react";
import * as React from "react";

Expand All @@ -19,6 +17,11 @@ declare global {

export interface RemixBrowserProps {}

interface Update {
action: Action;
location: Location;
}

/**
* The entry point for a Remix app when it is rendered in the browser (in
* `app/entry.client.js`). This component is used by React to hydrate the HTML
Expand All @@ -27,7 +30,7 @@ export interface RemixBrowserProps {}
export function RemixBrowser(_props: RemixBrowserProps): ReactElement {
let historyRef = React.useRef<BrowserHistory>();
if (historyRef.current == null) {
historyRef.current = createBrowserHistory({ window });
historyRef.current = createBrowserHistory({ window, v5Compat: true });
}

let history = historyRef.current;
Expand Down
12 changes: 7 additions & 5 deletions packages/remix-react/components.tsx
Original file line number Diff line number Diff line change
@@ -1,26 +1,28 @@
// TODO: We eventually might not want to import anything directly from `history`
// and leverage `react-router` here instead
import type { Action, Location } from "history";
import type {
FocusEventHandler,
FormHTMLAttributes,
MouseEventHandler,
TouchEventHandler,
} from "react";
import * as React from "react";
import type { Navigator, Params } from "react-router";
import type {
NavigationType as Action,
Location,
Navigator,
Params,
} from "react-router-dom";
import {
Router,
Link as RouterLink,
NavLink as RouterNavLink,
createPath,
useLocation,
useRoutes,
useNavigate,
useHref,
useResolvedPath,
} from "react-router-dom";
import type { LinkProps, NavLinkProps } from "react-router-dom";
import { createPath } from "history";
import type { SerializeFrom } from "@remix-run/server-runtime";

import type { AppData, FormEncType, FormMethod } from "./data";
Expand Down
4 changes: 1 addition & 3 deletions packages/remix-react/errorBoundaries.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
// TODO: We eventually might not want to import anything directly from `history`
// and leverage `react-router` here instead
import type { Location } from "history";
import React, { useContext } from "react";
import type { Location } from "react-router-dom";

import type {
CatchBoundaryComponent,
Expand Down
6 changes: 2 additions & 4 deletions packages/remix-react/links.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
// TODO: We eventually might not want to import anything directly from `history`
// and leverage `react-router` here instead
import type { Location } from "history";
import { parsePath } from "history";
import type { Location } from "react-router-dom";
import { parsePath } from "react-router-dom";

import type { AssetsManifest } from "./entry";
import type { ClientRoute } from "./routes";
Expand Down
2 changes: 1 addition & 1 deletion packages/remix-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"typings": "dist/index.d.ts",
"module": "dist/esm/index.js",
"dependencies": {
"history": "^5.3.0",
"@remix-run/router": "1.0.4",
"react-router-dom": "6.4.4"
},
"devDependencies": {
Expand Down
5 changes: 1 addition & 4 deletions packages/remix-react/routeMatching.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
// TODO: We eventually might not want to import anything directly from `history`
// and leverage `react-router` here instead
import type { Location } from "history";
import type { Params, RouteObject } from "react-router"; // TODO: export/import from react-router-dom
import type { Location, Params, RouteObject } from "react-router-dom";
import { matchRoutes } from "react-router-dom";

import type { ClientRoute } from "./routes";
Expand Down
5 changes: 1 addition & 4 deletions packages/remix-react/routeModules.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
// TODO: We eventually might not want to import anything directly from `history`
// and leverage `react-router` here instead
import type { Location } from "history";
import type { ComponentType } from "react";
import type { Params } from "react-router"; // TODO: import/export from react-router-dom
import type { Params, Location } from "react-router-dom";

import type { AppData } from "./data";
import type { LinkDescriptor } from "./links";
Expand Down
6 changes: 2 additions & 4 deletions packages/remix-react/server.tsx
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
// TODO: We eventually might not want to import anything directly from `history`
// and leverage `react-router` here instead
import type { Location, To } from "history";
import { Action, createPath } from "history";
import type { ReactElement } from "react";
import * as React from "react";
import type { Location, To } from "react-router-dom";
import { NavigationType as Action, createPath } from "react-router-dom";

import { RemixEntry } from "./components";
import type { EntryContext } from "./entry";
Expand Down
6 changes: 2 additions & 4 deletions packages/remix-react/transition.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
// TODO: We eventually might not want to import anything directly from `history`
// and leverage `react-router` here instead
import { Action } from "history";
import type { Location } from "history";
import { NavigationType as Action } from "react-router-dom";
import type { Location } from "react-router-dom";

import type { RouteData } from "./routeData";
import type { RouteMatch } from "./routeMatching";
Expand Down
3 changes: 1 addition & 2 deletions packages/remix-server-runtime/routeModules.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import type { Params } from "@remix-run/router";
import type { Location } from "history";
import type { ComponentType } from "react";
import type { Location, Params } from "react-router-dom";

import type { AppLoadContext, AppData } from "./data";
import type { LinkDescriptor } from "./links";
Expand Down
9 changes: 1 addition & 8 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1342,7 +1342,7 @@
dependencies:
regenerator-runtime "^0.13.4"

"@babel/runtime@^7.10.4", "@babel/runtime@^7.5.5", "@babel/runtime@^7.7.6", "@babel/runtime@^7.8.4":
"@babel/runtime@^7.10.4", "@babel/runtime@^7.5.5", "@babel/runtime@^7.8.4":
version "7.18.3"
resolved "https://registry.npmjs.org/@babel/runtime/-/runtime-7.18.3.tgz"
integrity sha512-38Y8f7YUhce/K7RMwTp7m0uCumpv9hZkitCbBClqQIow1qSbCvGkcegKOXpEWCQLfWmevgRiWokZ1GkpfhbZug==
Expand Down Expand Up @@ -7037,13 +7037,6 @@ headers-polyfill@^3.0.4:
resolved "https://registry.npmjs.org/headers-polyfill/-/headers-polyfill-3.0.7.tgz"
integrity sha512-JoLCAdCEab58+2/yEmSnOlficyHFpIl0XJqwu3l+Unkm1gXpFUYsThz6Yha3D6tNhocWkCPfyW0YVIGWFqTi7w==

history@^5.3.0:
version "5.3.0"
resolved "https://registry.npmjs.org/history/-/history-5.3.0.tgz"
integrity sha512-ZqaKwjjrAYUYfLG+htGaIIZ4nioX2L70ZUMIFysS3xvBsSG4x/n1V6TXV3N8ZYNuFGlDirFg32T7B6WOUPDYcQ==
dependencies:
"@babel/runtime" "^7.7.6"

hosted-git-info@^2.1.4:
version "2.8.9"
resolved "https://registry.npmjs.org/hosted-git-info/-/hosted-git-info-2.8.9.tgz"
Expand Down

0 comments on commit 902bdbd

Please sign in to comment.