-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change useScrollRestoration to use pagehide event #9945
Conversation
🦋 Changeset detectedLatest commit: 67dd17f The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
* Note: The `callback` argument should be a function created with | ||
* `React.useCallback()`. | ||
*/ | ||
function usePageHide( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not exported currently - but if this is indeed a better way to save off some data, maybe we should export it and make a note in the docs about the use-case difference between the two hooks?
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
pagehide
seems to be a better cross-browser way of detecting the unload of a page. And in the case of scroll restoration there's no need to ever prompt the user sopagehide
seems a better option anyway.From https://developer.mozilla.org/en-US/docs/Web/API/Window/unload_event#usage_notes:
Closes #9463