Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed createURL() for Firefox #9464

Merged
merged 2 commits into from
Oct 24, 2022

Conversation

AchThomas
Copy link
Contributor

window.location.origin is "null" (the literal string value) in Firefox under certain conditions: https://bugzilla.mozilla.org/show_bug.cgi?id=878297

This leads to a broken app in Firefox when you build for production and try to use it from the local file system in an HTML file.

I added an additional check in createURL() in router.ts to respect that case.

@changeset-bot
Copy link

changeset-bot bot commented Oct 14, 2022

⚠️ No Changeset found

Latest commit: ce4ef8b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Oct 14, 2022

Hi @AchThomas,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Oct 14, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@brophdawg11 brophdawg11 merged commit 2699759 into remix-run:dev Oct 24, 2022
@brophdawg11
Copy link
Contributor

Thanks!

@AchThomas AchThomas deleted the ff-window-location-origin-fix branch October 25, 2022 04:04
@brophdawg11
Copy link
Contributor

@AchThomas This is available in 6.4.3-pre.1 if you want to confirm that it's working!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants