Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History usage outside component. Resolve issue #8264 #9439

Closed
wants to merge 2 commits into from
Closed

History usage outside component. Resolve issue #8264 #9439

wants to merge 2 commits into from

Conversation

Arsikod
Copy link

@Arsikod Arsikod commented Oct 11, 2022

Add explanation to history issue
So users can rely on documents.

@changeset-bot
Copy link

changeset-bot bot commented Oct 11, 2022

⚠️ No Changeset found

Latest commit: c184e04

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Oct 11, 2022

Hi @Arsikod,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Oct 11, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@Arsikod Arsikod changed the title Document issue #8264 Resolve issue #8264 Oct 11, 2022
@Arsikod Arsikod changed the title Resolve issue #8264 History usage outside component. Resolve issue #8264 Oct 11, 2022
@timdorr
Copy link
Member

timdorr commented Oct 11, 2022

Thanks, but this is a fairly arbitrary place to add this. Instead, this belongs in an API page.

@timdorr timdorr closed this Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants