Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearly describe API of callback in code #7279

Merged
merged 2 commits into from
Apr 23, 2020
Merged

Clearly describe API of callback in code #7279

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ba1251
Clearly describe API of callback in code
kylemh Apr 23, 2020
22fb835
fix syntax error
kylemh Apr 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions packages/react-router/docs/api/Prompt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,15 @@ Will be called with the next `location` and `action` the user is attempting to n

```jsx
<Prompt
message={location =>
location.pathname.startsWith("/app")
message={(location, action) => {
if (action === 'POP') {
console.log("Backing up...")
}

return location.pathname.startsWith("/app")
? true
: `Are you sure you want to go to ${location.pathname}?`
}
}}
/>
```

Expand Down