fix(useParams): fix issue with useParams reading from null object #6940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed by returning empty object if route not mounted Closes #6938
|
@mjackson Is this what you envision being returned from |
|
I think returning |
|
Cool, I'm going to merge this in as-is. If it's not what was expected, I'll put in a fix myself. Thanks! |
|
This was released in 5.1.1 https://github.com/ReactTraining/react-router/releases/tag/v5.1.1 |
This was referenced Oct 6, 2019
[Snyk] Upgrade react-router-dom from 5.0.1 to 5.1.1
digitalmgmt2022/middle-reactjs-easy-sampletask#3
Open
This was referenced Oct 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed by returning empty object if route not mounted
Closes #6938