Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link should work with target="_self" #6138

Merged
merged 1 commit into from
Oct 15, 2018
Merged

Link should work with target="_self" #6138

merged 1 commit into from
Oct 15, 2018

Conversation

ericyang89
Copy link
Contributor

if target is _self act as target is falsy

@timdorr
Copy link
Member

timdorr commented May 9, 2018

Can you add a test for this as well?

@timdorr timdorr closed this May 9, 2018
@timdorr timdorr reopened this May 9, 2018
@timdorr timdorr changed the title if target is _self act as target is falsy Link should work with target="_self" May 9, 2018
@mjackson mjackson merged commit 079ebd3 into remix-run:master Oct 15, 2018
@mjackson
Copy link
Member

Thanks for the PR, @ericyang89! 👍

@lock lock bot locked as resolved and limited conversation to collaborators Dec 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericyang89 @timdorr @mjackson