Add failing tests for route matching with hash #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is an issue with |
|
actually, we'll merge this when history is updated just to be sure :) |
ryanflorence
added a commit
that referenced
this pull request
Sep 11, 2015
Add failing tests for route matching with hash
|
fixed with history 1.9.0 |
|
Awesome! Thanks @ryanflorence |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hash links don't seem to work, as far as I can tell. The router attempts to navigate to a route that includes the hash at the end of it, resulting in a route not found error. Attached are a couple of failing tests for the issue.
Related issue: #394