Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contxt types for Route.LoaderArgs, add upgrade docs #12145

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

brophdawg11
Copy link
Contributor

  • Remove optional context from Route.ClientLoaderArgs/Route.ClientActionArgs
  • Make context non-optional in Route.LoaderArgs/Route.ActionArgs
  • Add docs to the Remix v2 upgrade guide on how to use module augmentation to properly type LoaderFunctionArgs/ActionFunctionArgs for the migration

Copy link

changeset-bot bot commented Oct 17, 2024

⚠️ No Changeset found

Latest commit: e94409a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@brophdawg11 brophdawg11 changed the title Fix types for Route.LoaderArgs[context], add upgrade docs on AppLoadContext Fix contxt types for Route.LoaderArgs, add upgrade docs Oct 17, 2024
docs/upgrading/remix.md Outdated Show resolved Hide resolved
@brophdawg11 brophdawg11 merged commit 66613c0 into dev Oct 17, 2024
5 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/context-types branch October 17, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants