Fix crash on certain versions of Tizen and Samsung Internet

[tacheometry]

Issue description

A friend was having issues with Jellyfin on his Samsung Smart TV. Running the program, the following stack trace displayed:

It reads out: TypeError: Failed to construct 'Headers': No matching constructor signature.

Tracking this down, it is due to some react-router code. Turns out, this is due to a bug in Samsung's JavaScript implementation. new Headers(undefined) should be a valid constructor, but running this on Samsung, this errors. I suggested updating the browser, but this was not possible, as the version was locked.

Fix

Thus, like in other projects I've seen, I've implemented the fix of running the constructor with no parameters (new Headers()) instead of undefined or null (new Headers(undefined)).

This is inspired from the following work:

• new Headers(undefined) doesn't work with Samsung Internet 6.4 GoogleChrome/workbox#1461 with the fix of Use an empty object rather than undefined when calling new Headers() GoogleChrome/workbox#1463
• Failed to construct 'Headers': No matching constructor signature. connectrpc/connect-es#231 with the fix of added empty object if headers are undefined connectrpc/connect-es#232
• Should new Headers(undefined) throw? whatwg/fetch#185
• fix: pass empty object to headers initializer to prevent crash on chrome 49 unjs/ofetch#235

These changes increase compatibility, making it possible to run react-router on older browser implementations, and introduce no breaking changes.

After building using this fork of React Router, the program was no longer crashing on my friend's Tizen system.

[changeset-bot]

🦋 Changeset detected

Latest commit: 8d9ec2a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages

Name	Type
@remix-run/router	Patch
react-router	Patch
react-router-dom	Patch
react-router-dom-v5-compat	Patch
react-router-native	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[CLEMENTINATOR]

@tacheometry This issue is getting more attention since the jellyfin 10.9.x release. Is there any way you can fix the CI issue, repush and notify the maintainer ?
Best regards

[remix-cla-bot]

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

[tacheometry]

Should be good to go @CLEMENTINATOR

[tacheometry]

Regarding getting more attention on this, engagement from affected users might help

[newo-2001]

In that case I'll just mention that I am affected by this as well.

[dmitrylyzo]

webOS 4 (at least the emulator) has the same bug.