Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): add backticks to element names #10874

Merged
merged 6 commits into from
Sep 17, 2023
Merged

fix(docs): add backticks to element names #10874

merged 6 commits into from
Sep 17, 2023

Conversation

ayushmanchhabra
Copy link
Contributor

Fixes: #10872

@changeset-bot
Copy link

changeset-bot bot commented Sep 16, 2023

⚠️ No Changeset found

Latest commit: 9953187

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Sep 16, 2023

Hi @ayushmanchhabra,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Sep 16, 2023

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@ayushmanchhabra ayushmanchhabra changed the base branch from main to dev September 16, 2023 05:43
@timdorr
Copy link
Member

timdorr commented Sep 17, 2023

Thanks!

@timdorr timdorr merged commit da57748 into remix-run:dev Sep 17, 2023
3 checks passed
@ayushmanchhabra ayushmanchhabra deleted the docs/fix-element-names branch September 17, 2023 15:09
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.17.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.17.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs]: Some React element names are hidden when hovering over symbol in VS Code editor
3 participants