Fix webpack/terser startTransition minification bug in production mode #10588
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the
webpack
/terser
production build minification issue discovered in #10579 where in production mode the code would minify down such that the first half of the following ternary wouldn't actually be called:This would minify down to the following using
webpack
, whereconst _ = "startTransition"
andf
issetStateImpl
:Which expands to:
And thus
setStateImpl
(f
) never gets executed in the case thatReact.startTransition
is defined.This does not seem to be an issue building in production mode with
vite
, which minifies down to the following whereconst jE="startTransition"
andm
issetstateImpl
:and expands to:
Closes #10579 (partially)