Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing static propr for StaticRouterProvider #10401

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

brophdawg11
Copy link
Contributor

Fix SSR warnings about useLayoutEffect on the server since we were missing the static prop inside StaticRouterProvider (which is what useIsomorphicLayoutEffect relies on)

@changeset-bot
Copy link

changeset-bot bot commented Apr 26, 2023

🦋 Changeset detected

Latest commit: 5d30b98

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
react-router-dom Patch
react-router Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 merged commit b9e7401 into release-next Apr 26, 2023
@brophdawg11 brophdawg11 deleted the brophdawg11/static-prop branch April 26, 2023 17:43
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.11.0-pre.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.11.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants