Skip to content

Commit

Permalink
Hoist dependencies = smaller react-router-dom UMD (#5720)
Browse files Browse the repository at this point in the history
* Hoist dependencies = smaller react-router-dom UMD

Previously, react-router-dom's UMD builds contained duplicate code because they were fetching from both `packages/react-router/node-modules` and `packages/react-router-dom/node_modules`. With hoisting, this build is now
fetching from the root `node_modules`.

* eslint --fix the website.

* Update and sync packages.

* Fix website for React 16

* De-hoist RRN's react dep
  • Loading branch information
pshrmn authored and timdorr committed Nov 13, 2017
1 parent a3e6fac commit 463cd3e
Show file tree
Hide file tree
Showing 44 changed files with 3,290 additions and 4,839 deletions.
2 changes: 1 addition & 1 deletion packages/react-router-config/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"eslint-plugin-import": "^2.2.0",
"eslint-plugin-react": "^7.4.0",
"gzip-size": "^4.0.0",
"history": "^4.6.3",
"history": "^4.7.2",
"jest": "^21.2.1",
"pretty-bytes": "^4.0.2",
"raf": "^3.4.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/react-router-dom/rollup.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const config = {
}),
resolve({
customResolveOptions: {
moduleDirectory: ['node_modules', '../']
moduleDirectory: ['../../node_modules', '../']
}
}),
commonjs({
Expand Down
Loading

0 comments on commit 463cd3e

Please sign in to comment.