Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use stable tailwind flag #195

Merged

Conversation

MichaelDeBoey
Copy link
Member

@MichaelDeBoey MichaelDeBoey commented Feb 17, 2023

@runmoore
Copy link

Tested this change locally and it works perfectly 🥳

@machour
Copy link
Collaborator

machour commented Feb 22, 2023

@runmoore careful, you loose the autoprefixer that came free with tailwind

@runmoore
Copy link

@runmoore careful, you loose the autoprefixer that came free with tailwind

Sorry, I'm not sure what you mean. Could you elaborate? I thought this would be a no brainier, maybe I'm wrong?

@machour
Copy link
Collaborator

machour commented Feb 23, 2023

@runmoore juste a little inconvenience, that could be solved manually. Check this for more context: remix-run/remix#5475

@MichaelDeBoey MichaelDeBoey force-pushed the use-built-in-tailwindcss-support branch from 41691ee to 5730804 Compare March 16, 2023 19:12
@machour machour mentioned this pull request Mar 21, 2023
@MichaelDeBoey MichaelDeBoey force-pushed the use-built-in-tailwindcss-support branch from 5730804 to 91eca10 Compare March 23, 2023 21:14
@MichaelDeBoey MichaelDeBoey force-pushed the use-built-in-tailwindcss-support branch from 91eca10 to 8d39d21 Compare March 23, 2023 21:17
@brophdawg11
Copy link
Contributor

I think we should wait until future flags stabilize into a v2_ flag before we auto-enable them in templates/stacks. all the unstable_ CSS stuff should be getting rolled up into future.v2_dev in 1.16.0 so let's hold until then?

@MichaelDeBoey MichaelDeBoey force-pushed the use-built-in-tailwindcss-support branch 3 times, most recently from 1fe99bb to dbfb9bb Compare March 27, 2023 21:06
@MichaelDeBoey MichaelDeBoey force-pushed the use-built-in-tailwindcss-support branch from dbfb9bb to ba8c8ff Compare April 3, 2023 20:12
@MichaelDeBoey MichaelDeBoey changed the title feat: use new unstable_tailwindcss flag feat: use stable tailwindcss flag Apr 3, 2023
@MichaelDeBoey MichaelDeBoey marked this pull request as draft April 3, 2023 20:12
@MichaelDeBoey MichaelDeBoey force-pushed the use-built-in-tailwindcss-support branch from ba8c8ff to 3e23c21 Compare April 3, 2023 20:20
@MichaelDeBoey MichaelDeBoey changed the title feat: use stable tailwindcss flag feat: use stable tailwind flag Apr 3, 2023
@mcansh
Copy link
Contributor

mcansh commented Apr 17, 2023

you lose the autoprefixer that came free with tailwind

can we add a postcss.config.js file and autoprefixer as a devDep?

module.exports = {
  plugins: [require("autoprefixer")],
};

and add postcss: true to remix.config

@brophdawg11
Copy link
Contributor

Just confirming, we have to wait until we release 1.16.0 before we can merge this, correct?

@MichaelDeBoey
Copy link
Member Author

we have to wait until we release 1.16.0 before we can merge this, correct?

@brophdawg11 That's correct.
Hence why I keep this in draft for now

@MichaelDeBoey MichaelDeBoey force-pushed the use-built-in-tailwindcss-support branch 3 times, most recently from 0568b53 to 28b415c Compare April 24, 2023 16:40
@mcansh mcansh self-assigned this Apr 25, 2023
@MichaelDeBoey MichaelDeBoey force-pushed the use-built-in-tailwindcss-support branch from 28b415c to 9b284a2 Compare April 29, 2023 21:22
@MichaelDeBoey MichaelDeBoey marked this pull request as ready for review May 1, 2023 20:07
@MichaelDeBoey MichaelDeBoey merged commit c56b28e into remix-run:main May 1, 2023
@MichaelDeBoey MichaelDeBoey deleted the use-built-in-tailwindcss-support branch May 1, 2023 20:09
@@ -0,0 +1,6 @@
module.exports = {
plugins: {
tailwindcss: {},
Copy link

@silvenon silvenon May 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering, why was tailwindcss added to the PostCSS configuration as well? Wasn't the fix only to add autoprefixer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants