Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds history.push() and history.replace() methods #118

Merged
merged 1 commit into from
Oct 29, 2015

Conversation

th0r
Copy link

@th0r th0r commented Oct 29, 2015

This allows to omit state parameter: history.pushState(null, '/home') => history.push('/home')

See #113 for more info.

@knowbody
Copy link
Contributor

@th0r looks good to me! could you just remove the .editorconfig we don't need it. and also please squash your commits.

Thanks a lot for that!

@th0r th0r force-pushed the push-replace-methods branch from 471e631 to ccdf8a9 Compare October 29, 2015 12:20
@th0r
Copy link
Author

th0r commented Oct 29, 2015

Done

knowbody added a commit that referenced this pull request Oct 29, 2015
Adds `history.push()` and `history.replace()` methods
@knowbody knowbody merged commit 3bce361 into remix-run:master Oct 29, 2015
@knowbody
Copy link
Contributor

thank you!

@knowbody knowbody mentioned this pull request Oct 29, 2015
@th0r
Copy link
Author

th0r commented Oct 29, 2015

@knowbody No problem!)

@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants