Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for hashes without leading slash #249

Closed
zdila opened this issue Mar 18, 2016 · 3 comments
Closed

add support for hashes without leading slash #249

zdila opened this issue Mar 18, 2016 · 3 comments

Comments

@zdila
Copy link

zdila commented Mar 18, 2016

createHashHistory could have an option to prevent leading slash in the hash.

Instead of index.html#/foo the URL would then be index.html#foo.

@taion
Copy link
Contributor

taion commented Mar 18, 2016

Might be worth thinking about this in conjunction with #131 and remix-run/react-router#601. It sounds like we need some flexibility in supporting various hash URL schemes to both offer appropriate legacy support and allow interop with e.g. Auth0.

@mjackson
Copy link
Member

That's not a bad idea, @zdila, but it introduces extra complexity for not a lot of gain IMO. I think I'd rather leave it as it is now unless there's a stronger argument than aesthetics.

@zdila
Copy link
Author

zdila commented Mar 27, 2016

Aesthetics is a strong argument nowadays :-). In any case we'll try to implement our own HashProtocol then because feature we request is a critical issue for our customer.

@mjackson mjackson closed this as completed May 3, 2016
mjackson added a commit that referenced this issue Jul 16, 2016
hashType may be any of "slash" (the default), "hashbang", or "noslash"
to use different styles of hash URLs.

Fixes #278
Fixes #249
@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants