append MAgPIE results in reporting.R, not in start_coupled.R #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orichters
force-pushed
the
startscripts
branch
from
c9f6d02
to
23ab0ac
Compare
dklein-pik
reviewed
Oct 5, 2022
|
|
||
| message("end generation of EDGE-T reporting") | ||
| } | ||
|
|
||
| configfile <- file.path(outputdir, "config.Rdata") |
There was a problem hiding this comment.
I realize only now that this has the disadvantage of making reporting.R dependent on the existence of the config file. There is, however, no other way, unless we write the path to the magpie report into the gdx, which is a bit too much for now, I think. So, long story short: I'm fine with this solution :-)
There was a problem hiding this comment.
reporting.R depends on config.Rdata anyhow: It calls lucode2::getScenNames() which reads from it.
There was a problem hiding this comment.
Ah, missed that. Thanks!
dklein-pik
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
start_coupled.Rtoreporting.Rmagpie4::reportEmissions()failed for some reasonType of change
Checklist:
/p/tmp/oliverr/remind-smallfix/output/test_*folders with coupled runs, also startingreportingviaoutput.Rworked for both coupled and non-coupled run.