MAgPIE coupling: use defaults from MAgPIE's default.cfg for list of MAgPIE outputs #1880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurinks
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
Thanks, @dklein-pik, for the quick implementation! Looks good to me. If I understand it right, this means that REMIND runs a limited reporting between iterations and full reporting after the last iteration. MAgPIE runs the full reporting after each iteration. I suppose that this does not cost too much run time, i.e. no need to reduce the MAgPIE reporting between iterations. Agree?
|
That's right. According to Florian the additional script takes only 5 minutes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
So far the couplig did not use the list of output scripts as defined in MAgPIE's default.cfg, instead only
rds_reportwas specified explicitely overwriting the defaults. Since the list of required/useful output scripts change from time to time we switch to using the defaults from MAgPIE's default.cfg, now includingextra/disaggregation.