Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate MAGICC6 #1879

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

Conversation

tonnrueter
Copy link
Contributor

Purpose of this PR

Removes MAGICC6 based climate assessment from REMIND

Type of change

(Make sure to delete from the Type-of-change list the items not relevant to your PR)

  • Bug fix
  • Refactoring
  • New feature
  • Minor change (default scenarios show only small differences)
  • Fundamental change
  • This change requires a documentation update

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • All automated model tests pass (FAIL 0 in the output of make test)
  • The changelog CHANGELOG.md has been updated correctly

Further information (optional):

  • Test runs are here:
  • Comparison of results (what changes by this PR?):

@tonnrueter
Copy link
Contributor Author

Oh boy, this feels delicate...

I've never worked on the REMIND/GAMS core and I need y'all to please tell me how much this messes things up. It compiles and runs testOneRegi is all I can say:

  • I have no idea how this will effect remind2
  • There's still a plethora of references to the magicc6 realization of the 15_climate module in the scenario configs
  • make test returns 2 failures:
Failure (test_01-codeCheck.R:13:3): GAMS code follows the coding etiquette
Failure (test_01-readCheckScenarioConfig.R:14:5): perform readCheckScenarioConfig with scenario_config_NGFS_v5.csv

The latter of which seems to be related to the scenario configs

@@ -1911,7 +1910,6 @@ $include "./core/loop.gms";
$ifthen.c_skip_output %c_skip_output% == "off"
$include "./core/output.gms";
$batinclude "./modules/include.gms" output
$include "./core/magicc.gms"; !!connection to MAGICC, needed for post-processing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does ./core/magicc.gms still exist?

Copy link
Contributor Author

@tonnrueter tonnrueter Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The core/magicc.gms file seems to have survived the purge 🤔 Thanks! I've removed it now

Copy link
Contributor

@dklein-pik dklein-pik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants