-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate MAGICC6 #1879
base: develop
Are you sure you want to change the base?
Deprecate MAGICC6 #1879
Conversation
Oh boy, this feels delicate... I've never worked on the REMIND/GAMS core and I need y'all to please tell me how much this messes things up. It compiles and runs
Failure (test_01-codeCheck.R:13:3): GAMS code follows the coding etiquette
Failure (test_01-readCheckScenarioConfig.R:14:5): perform readCheckScenarioConfig with scenario_config_NGFS_v5.csv The latter of which seems to be related to the scenario configs |
@@ -1911,7 +1910,6 @@ $include "./core/loop.gms"; | |||
$ifthen.c_skip_output %c_skip_output% == "off" | |||
$include "./core/output.gms"; | |||
$batinclude "./modules/include.gms" output | |||
$include "./core/magicc.gms"; !!connection to MAGICC, needed for post-processing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does ./core/magicc.gms
still exist?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The core/magicc.gms
file seems to have survived the purge 🤔 Thanks! I've removed it now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Purpose of this PR
Removes MAGICC6 based climate assessment from REMIND
Type of change
(Make sure to delete from the Type-of-change list the items not relevant to your PR)
Checklist:
remind2
where it was neededforbiddenColumnNames
in readCheckScenarioConfig.R in case the PR leads to deprecated switchesFAIL 0
in the output ofmake test
)CHANGELOG.md
has been updated correctlyFurther information (optional):