Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning to RCP scenarios that are not actively maintained. #1861

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

laurinks
Copy link
Contributor

@laurinks laurinks commented Oct 11, 2024

Purpose of this PR

See title and this issue.

Type of change

  • Minor addition to documentation

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • All automated model tests pass (FAIL 0 in the output of make test)
  • The changelog CHANGELOG.md has been updated correctly

Copy link
Contributor

@orichters orichters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That might be actually something to put into https://github.com/remindmodel/remind/blob/develop/scripts/start/checkFixCfg.R, creating an actual warning that shows up in the log in case you use it.

@laurinks
Copy link
Contributor Author

laurinks commented Oct 11, 2024

Again what learned! ;) Thanks for the suggestion, @orichters ! I added it.

scripts/start/checkFixCfg.R Outdated Show resolved Hide resolved
@laurinks laurinks merged commit b360b8e into remindmodel:develop Oct 11, 2024
2 checks passed
@laurinks laurinks deleted the rcp-doc branch October 11, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants